[Lldb-commits] [lldb] [lldb] Handle STT_TLS symbol type in ELF parser (PR #178975)

[Minsoo Choo via lldb-commits]

================
@@ -8,7 +8,7 @@
 
 
 class PlatformProcessCrashInfoTestCase(TestBase):
-    @expectedFailureAll(oslist=["windows", "linux", "freebsd", "netbsd"])
+    @expectedFailureAll(oslist=["windows", "freebsd", "netbsd"])
----------------
mchoo7 wrote:

I don't think this needs testing since FreeBSD's builtin elfdump already handles this (https://github.com/freebsd/freebsd-src/blob/8c40c7bb361f0c8b595bfee9dc6f8790e0eb6d68/usr.bin/elfdump/elfdump.c#L433). Since this is just parser and doesn't do anything more, I think this is fine. I cannot speak for netbsd because I've never used it, but Github code search shows that at least its system headers define STT_TLS (https://github.com/search?q=repo%3ANetBSD%2Fsrc%20STT_TLS&type=code). However, I can't see where it is actually used.

Side note: Shouldn't we include Darwin (macOS, iOS, etc) here? They use mach-o.

https://github.com/llvm/llvm-project/pull/178975