[Lldb-commits] [lldb] [LLDB]Fix logic in matches method for thread comparison (PR #179873)
Priyanshu Kumar via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 4 23:01:08 PST 2026
https://github.com/Priyanshu3820 created https://github.com/llvm/llvm-project/pull/179873
The method claims to check if a is a subset of b, but the implementation `a | b ==a` actually checks if b is a subset of a. This patch fixes that.
>From 2ed013156a86dc735e13fe72ba55eaa105a698ae Mon Sep 17 00:00:00 2001
From: Priyanshu Kumar <10b.priyanshu at gmail.com>
Date: Thu, 5 Feb 2026 12:28:46 +0530
Subject: [PATCH] Update TestDAP_stopped_events.py
---
.../API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py b/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py
index 03dff39c82ed9..06d58fc6ff97d 100644
--- a/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py
+++ b/lldb/test/API/tools/lldb-dap/stopped-events/TestDAP_stopped_events.py
@@ -16,7 +16,7 @@ class TestDAP_stopped_events(lldbdap_testcase.DAPTestCaseBase):
def matches(self, a: dict, b: dict) -> bool:
"""Returns true if 'a' is a subset of 'b', otherwise false."""
- return a | b == a
+ return b | a == b
def verify_threads(self, expected_threads):
threads_resp = self.dap_server.request_threads()
More information about the lldb-commits
mailing list