[Lldb-commits] [lldb] [lldb] Handle STT_TLS symbol type in ELF parser (PR #178975)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> You need to fix the conflicts with the main branch before the CI can run again (it applies your changes to main to simulate the post-merge situation).

Now I think about it, I'm not sure why it's being so picky, it isn't normally. Oh well, since there aren't any outstanding comments on this, feel free to force push updates.

> which uses the DWARF DW_OP_form_tls_address opcode to calculate thread-local addresses.

> I don't know the details but I'd like to note that, as I said, this symbol is available even on a stripped glibc, i.e. with no dwarf

This makes me worry that this PR is an improvement but not a full fix for the issue as reported. I'd still be happy to accept this PR but we should check before we claim to have fixed it. @mugiwaraluffy56 can you reproduce the issue and see what happens?

Other than that, this looks nice, the YAML test in particular is very neat. I'm just holding off approving until we know its exact effects.

https://github.com/llvm/llvm-project/pull/178975