[Lldb-commits] [lldb] [lldb] Step over non-lldb breakpoints (PR #174348)

[David Spickett via lldb-commits]

================
@@ -229,3 +231,12 @@ Instruction *ArchitectureMips::GetInstructionAtAddress(
 
   return nullptr;
 }
+
+bool ArchitectureMips::IsValidBreakpointInstruction(
+    llvm::ArrayRef<uint8_t> reference, llvm::ArrayRef<uint8_t> observed) const {
+  // The middle twenty bits of BREAK can be anything, so zero them
+  uint32_t mask = 0xFC00003F;
+  auto ref_bytes = llvm::support::endian::read32le(reference.data());
+  auto bytes = llvm::support::endian::read32le(observed.data());
+  return (ref_bytes & mask) == (bytes & mask);
+}
----------------
DavidSpickett wrote:

MIPS a rare case where LE might be less common. Worst case it gets stuck on a random breakpoint.

https://github.com/llvm/llvm-project/pull/174348