[Lldb-commits] [lldb] [lldb] Handle STT_TLS symbol type in ELF parser (PR #178975)

[David Spickett via lldb-commits]

DavidSpickett wrote:

You need to fix the conflicts with the main branch before the CI can run again (it applies your changes to main to simulate the post-merge situation).

This needs a targeted test case. The ideal for this is to put it in lldb/test/Shell/ObjectFile/ELF and generate the input from a YAML file. LLVM has tools obj2yaml and yaml2obj for this purpose, or you could modify one of the existing yaml files.

If you need to check more than that style of test can, a simple C program can be used. I expect such a test will fail on AArch64 (https://github.com/llvm/llvm-project/issues/83466 / https://github.com/llvm/llvm-project/issues/71666) and probably ARM. We can sort that out with post merge fixes if so.

There is a test for TLS global variables - lldb/test/API/lang/c/tls_globals/TestTlsGlobals.py. This does run on x86 Linux judging by the skip annotations. errno is a "global" so you could check access in that test.

https://github.com/llvm/llvm-project/pull/178975