[Lldb-commits] [lldb] [lldb-dap] Conditionally check UBSan stack trace on Darwin only (PR #178655)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

<details>
<summary>Changes</summary>

non-darwin platforms may have incorrect stop information location heuristics. Enable assertion once UBSan stopInfo heuristic is updated.

I hit this locally, I don't see it hitting any CI bot but should, Mostly likely the CI linux bots may not have `compiler_rt` run time enabled. 
see https://github.com/llvm/llvm-project/pull/177964#discussion_r2732271531

---
Full diff: https://github.com/llvm/llvm-project/pull/178655.diff


1 Files Affected:

- (modified) lldb/test/API/tools/lldb-dap/exception/runtime-instruments/TestDAP_runtime_instruments.py (+5-1) 


``````````diff
diff --git a/lldb/test/API/tools/lldb-dap/exception/runtime-instruments/TestDAP_runtime_instruments.py b/lldb/test/API/tools/lldb-dap/exception/runtime-instruments/TestDAP_runtime_instruments.py
index 3fa7aca91a926..ffc02c9b60fd7 100644
--- a/lldb/test/API/tools/lldb-dap/exception/runtime-instruments/TestDAP_runtime_instruments.py
+++ b/lldb/test/API/tools/lldb-dap/exception/runtime-instruments/TestDAP_runtime_instruments.py
@@ -22,4 +22,8 @@ def test_ubsan(self):
         self.assertEqual(exceptionInfo["breakMode"], "always")
         self.assertRegex(exceptionInfo["description"], r"Out of bounds index")
         self.assertEqual(exceptionInfo["exceptionId"], "runtime-instrumentation")
-        self.assertIn("main.c", exceptionInfo["details"]["stackTrace"])
+
+        # FIXME: Check on non macOS platform the stop infomation location heuristic
+        # may be wrong. enable when we have updated Ubsan stopInfo heuristic.
+        if self.platformIsDarwin():
+            self.assertIn("main.c", exceptionInfo["details"]["stackTrace"])

``````````

</details>


https://github.com/llvm/llvm-project/pull/178655