[Lldb-commits] [lldb] [lldb] Move ValueImpl and ValueLocker to ValueObject, NFC. (PR #178573)

[Jonas Devlieghere via lldb-commits]

https://github.com/JDevlieghere approved this pull request.

As a reminder, the SB API provides ABI stability. Unless I'm forgetting about something, this transformation is ABI safe, because the type being moved is:

1. Not part of the `lldb` namespace,
2. Only used by private and protected methods of `SBValue`,
3. Doesn't change the layout/size of `SBValue`. 

So that looks fine. Since you're already touching this, please consider removing some of the else-after-returns that are prevalent in the old code. Otherwise LGTM.

https://github.com/llvm/llvm-project/pull/178573