[Lldb-commits] [lldb] [lldb][NFC] Module, ModuleSpec, GetSectionData use DataExtractorSP (PR #178347)

[Jonas Devlieghere via lldb-commits]

================
@@ -220,17 +220,18 @@ bool ObjectContainerMachOFileset::ParseHeader() {
 }
 
 size_t ObjectContainerMachOFileset::GetModuleSpecifications(
-    const lldb_private::FileSpec &file, lldb::DataBufferSP &data_sp,
+    const lldb_private::FileSpec &file, lldb::DataExtractorSP &extractor_sp,
     lldb::offset_t data_offset, lldb::offset_t file_offset,
     lldb::offset_t file_size, lldb_private::ModuleSpecList &specs) {
   const size_t initial_count = specs.GetSize();
+  if (!extractor_sp)
+    return initial_count;
----------------
JDevlieghere wrote:

Alright, for this PR, let's keep the existing behavior and make sure we do what the old code did. I've filed https://github.com/llvm/llvm-project/issues/178625 to address this in the future.

https://github.com/llvm/llvm-project/pull/178347