[Lldb-commits] [lldb] [lldb] Improve error and docs for repeating "memory region" (PR #177559)

[via lldb-commits]

================
@@ -1735,7 +1741,25 @@ class CommandObjectMemoryRegion : public CommandObjectParsed {
     const size_t argc = command.GetArgumentCount();
     const lldb::ABISP &abi = process_sp->GetABI();
 
-    if (argc == 1) {
+    if (argc == 0) {
+      if (!m_memory_region_options.m_all) {
+        if ( // When we're repeating the command, the previous end
+             // address is used for load_addr. If that was 0xF...F then
+             // we must have reached the end of memory.
+            (load_addr == LLDB_INVALID_ADDRESS) ||
+            // If the target has non-address bits (tags, limited virtual
+            // address size, etc.), the end of mappable memory will be
+            // lower than that. So if we find any non-address bit set,
+            // we must be at the end of the mappable range.
+            (abi && (abi->FixAnyAddress(load_addr) != load_addr))) {
+          result.AppendErrorWithFormat(
+              "No next region address set, one address expression argument or "
----------------
jimingham wrote:

You are saying "no next region address set THEREFORE one address... required".

Without the therefore, it sounds like these are three coequal facts, which could be confusing.  You could even do:

No next region address set: one...

That says the other two are the result of the first fact.

Other than that this LGTM.

https://github.com/llvm/llvm-project/pull/177559