[Lldb-commits] [lldb] [lldb-dap] Join the ProgressEventReporter thread if possible (PR #176984)

Ebuka Ezike via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 20 09:59:45 PST 2026


https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/176984

It is not easily noticeable because it's mostly happens when ending the debug session.

>From 7c117e9fd8ce22fae6a9f00c56bfe862e9f7cb58 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Tue, 20 Jan 2026 17:58:03 +0000
Subject: [PATCH] [lldb-dap] Join the ProgressEventReporter thread if possible

It is not easily noticable because it's mostly
happens when ending the debug session.
---
 lldb/tools/lldb-dap/ProgressEvent.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lldb/tools/lldb-dap/ProgressEvent.cpp b/lldb/tools/lldb-dap/ProgressEvent.cpp
index e53ec40180a6d..5ef03ccb24bb9 100644
--- a/lldb/tools/lldb-dap/ProgressEvent.cpp
+++ b/lldb/tools/lldb-dap/ProgressEvent.cpp
@@ -195,7 +195,8 @@ ProgressEventReporter::ProgressEventReporter(
 
 ProgressEventReporter::~ProgressEventReporter() {
   m_thread_should_exit = true;
-  m_thread.join();
+  if (m_thread.joinable())
+    m_thread.join();
 }
 
 void ProgressEventReporter::ReportStartEvents() {



More information about the lldb-commits mailing list