[Lldb-commits] [lldb] [LLDB] Close previously opened handles in `PseudoConsole` (PR #176775)

[Charles Zablit via lldb-commits]

================
@@ -64,10 +64,16 @@ struct Kernel32 {
 
 static Kernel32 kernel32;
 
+PseudoConsole::~PseudoConsole() { Close(); }
+
 llvm::Error PseudoConsole::OpenPseudoConsole() {
   if (!kernel32.IsConPTYAvailable())
     return llvm::make_error<llvm::StringError>("ConPTY is not available",
                                                llvm::errc::io_error);
+
+  // close any previously opened handles
+  Close();
----------------
charles-zablit wrote:

Just to confirm: this is needed only if we call `OpenPseudoConsole` twice on the same `PseudoConsole` instance?

https://github.com/llvm/llvm-project/pull/176775