[Lldb-commits] [lldb] [lldb-dap] separate the --stdio flag in 3 separate flags (PR #176778)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>tools/lldb/tools/lldb-dap/tool/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o</summary>

```
FAILED: tools/lldb/tools/lldb-dap/tool/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o
sccache /opt/llvm/bin/clang++ -DHAVE_ROUND -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/tools/lldb-dap/tool -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/tools/lldb-dap -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/usr/include/python3.12 -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/lldb/tools/lldb-dap/tool/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o -MF tools/lldb/tools/lldb-dap/tool/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o.d -o tools/lldb/tools/lldb-dap/tool/CMakeFiles/lldb-dap.dir/lldb-dap.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:268:8: error: use of undeclared identifier 'stdio'; did you mean 'stdin'?
268 |   if (!stdio.empty()) {
|        ^~~~~
|        stdin
/usr/include/stdio.h:149:14: note: 'stdin' declared here
149 | extern FILE *stdin;             /* Standard input stream.  */
|              ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:268:13: error: member reference type 'FILE *' (aka '_IO_FILE *') is a pointer; did you mean to use '->'?
268 |   if (!stdio.empty()) {
|        ~~~~~^
|             ->
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:268:14: error: no member named 'empty' in '_IO_FILE'
268 |   if (!stdio.empty()) {
|        ~~~~~ ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:271:5: error: use of undeclared identifier 'stdio'; did you mean 'stdin'?
271 |     stdio.split(stdio_files, ':');
|     ^~~~~
|     stdin
/usr/include/stdio.h:149:14: note: 'stdin' declared here
149 | extern FILE *stdin;             /* Standard input stream.  */
|              ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:271:10: error: member reference type 'FILE *' (aka '_IO_FILE *') is a pointer; did you mean to use '->'?
271 |     stdio.split(stdio_files, ':');
|     ~~~~~^
|          ->
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:271:11: error: no member named 'split' in '_IO_FILE'
271 |     stdio.split(stdio_files, ':');
|     ~~~~~ ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:273:27: error: no matching function for call to 'SetupIORedirection'
273 |     if (llvm::Error err = SetupIORedirection(stdio_files))
|                           ^~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:197:20: note: candidate function not viable: requires 3 arguments, but 1 was provided
197 | static llvm::Error SetupIORedirection(llvm::StringRef stdin_path,
|                    ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~
198 |                                       llvm::StringRef stdout_path,
|                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
199 |                                       llvm::StringRef stderr_path) {
|                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/tools/lldb-dap/tool/lldb-dap.cpp:274:14: error: call to deleted constructor of 'llvm::Error'
274 |       return err;
|              ^~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Error.h:191:3: note: 'Error' has been explicitly marked deleted here
191 |   Error(const Error &Other) = delete;
|   ^
8 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/176778