[Lldb-commits] [lldb] [lldb][NFC] Make parameter const in SymbolFile::GetParameterStackSize (PR #176220)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/176220.diff


5 Files Affected:

- (modified) lldb/include/lldb/Symbol/SymbolFile.h (+1-1) 
- (modified) lldb/include/lldb/Symbol/SymbolFileOnDemand.h (+2-1) 
- (modified) lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp (+1-1) 
- (modified) lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h (+2-1) 
- (modified) lldb/source/Symbol/SymbolFileOnDemand.cpp (+1-1) 


``````````diff
diff --git a/lldb/include/lldb/Symbol/SymbolFile.h b/lldb/include/lldb/Symbol/SymbolFile.h
index 9982852cc760d..ce3fe18771adb 100644
--- a/lldb/include/lldb/Symbol/SymbolFile.h
+++ b/lldb/include/lldb/Symbol/SymbolFile.h
@@ -397,7 +397,7 @@ class SymbolFile : public PluginInterface {
 
   /// Return the number of stack bytes taken up by the parameters to this
   /// function.
-  virtual llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) {
+  virtual llvm::Expected<lldb::addr_t> GetParameterStackSize(const Symbol &symbol) {
     return llvm::createStringError(make_error_code(llvm::errc::not_supported),
                                    "Operation not supported.");
   }
diff --git a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
index b376de73419d4..6807ae2df8faa 100644
--- a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
+++ b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
@@ -175,7 +175,8 @@ class SymbolFileOnDemand : public lldb_private::SymbolFile {
   GetUnwindPlan(const Address &address,
                 const RegisterInfoResolver &resolver) override;
 
-  llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) override;
+  llvm::Expected<lldb::addr_t>
+  GetParameterStackSize(const Symbol &symbol) override;
 
   void PreloadSymbols() override;
 
diff --git a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
index 14932e957d081..39f21250649d8 100644
--- a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
+++ b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
@@ -498,7 +498,7 @@ void SymbolFileBreakpad::AddSymbols(Symtab &symtab) {
 }
 
 llvm::Expected<lldb::addr_t>
-SymbolFileBreakpad::GetParameterStackSize(Symbol &symbol) {
+SymbolFileBreakpad::GetParameterStackSize(const Symbol &symbol) {
   ParseUnwindData();
   if (auto *entry = m_unwind_data->win.FindEntryThatContains(
           symbol.GetAddress().GetFileAddress())) {
diff --git a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
index 041b388f9f344..0bf67518efd5c 100644
--- a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
+++ b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
@@ -132,7 +132,8 @@ class SymbolFileBreakpad : public SymbolFileCommon {
 
   void AddSymbols(Symtab &symtab) override;
 
-  llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) override;
+  llvm::Expected<lldb::addr_t>
+  GetParameterStackSize(const Symbol &symbol) override;
 
   lldb::UnwindPlanSP
   GetUnwindPlan(const Address &address,
diff --git a/lldb/source/Symbol/SymbolFileOnDemand.cpp b/lldb/source/Symbol/SymbolFileOnDemand.cpp
index 9fc13c5989fc2..13ef8c70f7dc1 100644
--- a/lldb/source/Symbol/SymbolFileOnDemand.cpp
+++ b/lldb/source/Symbol/SymbolFileOnDemand.cpp
@@ -508,7 +508,7 @@ SymbolFileOnDemand::GetUnwindPlan(const Address &address,
 }
 
 llvm::Expected<lldb::addr_t>
-SymbolFileOnDemand::GetParameterStackSize(Symbol &symbol) {
+SymbolFileOnDemand::GetParameterStackSize(const Symbol &symbol) {
   if (!m_debug_info_enabled) {
     Log *log = GetLog();
     LLDB_LOG(log, "[{0}] {1} is skipped", GetSymbolFileName(), __FUNCTION__);

``````````

</details>


https://github.com/llvm/llvm-project/pull/176220