[Lldb-commits] [lldb] [lldb] Fix settings set to accept values starting with dash (PR #176076)

[via lldb-commits]

jimingham wrote:

This would lead to some surprising results.  For instance, if I ran:

`(lldb) settings set target.run-args -first -second -e -g
`
then the run args passed to the target would actually be `-first -second` because settings set would have absorbed the -e and the -g (which are options to settings set).

That's too confusing, I don't think this is the right thing to do.

settings set is a raw command.  It tells you how to use it at the end of the help:

```
(lldb) help settings set
...
     This command takes options and free-form arguments.  If your arguments resemble option specifiers (i.e., they start with a - or --), you must use ' -- ' between the end of the command options and the beginning of the arguments.

```

So I think we've given people enough information to call the command correctly, and doing it behind people's back doesn't seem like the right thing to do, especially since it can lead to some unexpected results.

https://github.com/llvm/llvm-project/pull/176076