[Lldb-commits] [lldb] [lldb] skip the python interactive I/O test on windows (PR #175055)

Ebuka Ezike via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 8 11:53:09 PST 2026


https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/175055

>From 807f4656fd0d9a70c3b1f18e2846e7b367d421eb Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Thu, 8 Jan 2026 19:28:00 +0000
Subject: [PATCH 1/2] [lldb] skip the python interactive I/O test on windows

---
 lldb/test/API/python_api/file_handle/TestFileHandle.py | 1 +
 lldb/test/Shell/ScriptInterpreter/Python/io.test       | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/lldb/test/API/python_api/file_handle/TestFileHandle.py b/lldb/test/API/python_api/file_handle/TestFileHandle.py
index 707044a3afb0f..b69724ec8db11 100644
--- a/lldb/test/API/python_api/file_handle/TestFileHandle.py
+++ b/lldb/test/API/python_api/file_handle/TestFileHandle.py
@@ -680,6 +680,7 @@ def test_stdout_file(self):
             lines = [x for x in f.read().strip().split() if x != "7"]
             self.assertEqual(lines, ["foobar"])
 
+    @skipIfWindows
     def test_stdout_file_interactive(self):
         """Ensure when we read stdin from a file, outputs from python goes to the right I/O stream."""
         with open(self.in_filename, "w") as f:
diff --git a/lldb/test/Shell/ScriptInterpreter/Python/io.test b/lldb/test/Shell/ScriptInterpreter/Python/io.test
index 25e3de41724e0..1a3ff8dcd4258 100644
--- a/lldb/test/Shell/ScriptInterpreter/Python/io.test
+++ b/lldb/test/Shell/ScriptInterpreter/Python/io.test
@@ -1,3 +1,5 @@
+# UNSUPPORTED: system-windows
+
 # RUN: rm -rf %t.stdout %t.stderr
 # RUN: cat %s | %lldb --script-language python > %t.stdout 2> %t.stderr
 # RUN: cat %t.stdout | FileCheck %s --check-prefix STDOUT

>From ba7455a5edd96a849fe3520f602c48c49f1f54e2 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Thu, 8 Jan 2026 19:52:07 +0000
Subject: [PATCH 2/2] add review changes

---
 lldb/test/API/python_api/file_handle/TestFileHandle.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lldb/test/API/python_api/file_handle/TestFileHandle.py b/lldb/test/API/python_api/file_handle/TestFileHandle.py
index b69724ec8db11..70720e3f0fa91 100644
--- a/lldb/test/API/python_api/file_handle/TestFileHandle.py
+++ b/lldb/test/API/python_api/file_handle/TestFileHandle.py
@@ -2,7 +2,6 @@
 Test lldb Python API for file handles.
 """
 
-
 import os
 import io
 import re
@@ -680,7 +679,7 @@ def test_stdout_file(self):
             lines = [x for x in f.read().strip().split() if x != "7"]
             self.assertEqual(lines, ["foobar"])
 
-    @skipIfWindows
+    @skipIf(hostoslist=["windows"])
     def test_stdout_file_interactive(self):
         """Ensure when we read stdin from a file, outputs from python goes to the right I/O stream."""
         with open(self.in_filename, "w") as f:



More information about the lldb-commits mailing list