[Lldb-commits] [lldb] [lldb] Don't trim expression in progress event (PR #174609)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

<details>
<summary>Changes</summary>

Trimming the content of the progress event is the responsibility of the consumer, not the producer. For example, when using the statusline, there's plenty of space to show longer expressions.

rdar://166879951

---
Full diff: https://github.com/llvm/llvm-project/pull/174609.diff


1 Files Affected:

- (modified) lldb/source/Expression/UserExpression.cpp (+3-8) 


``````````diff
diff --git a/lldb/source/Expression/UserExpression.cpp b/lldb/source/Expression/UserExpression.cpp
index 5563eba21777e..ff7a356dbbb1e 100644
--- a/lldb/source/Expression/UserExpression.cpp
+++ b/lldb/source/Expression/UserExpression.cpp
@@ -427,15 +427,10 @@ UserExpression::Execute(DiagnosticManager &diagnostic_manager,
                         lldb::ExpressionVariableSP &result_var) {
   Debugger *debugger =
       exe_ctx.GetTargetPtr() ? &exe_ctx.GetTargetPtr()->GetDebugger() : nullptr;
-  std::string details;
-  if (m_options.IsForUtilityExpr())
-    details = "LLDB utility";
-  else if (m_expr_text.size() > 15)
-    details = m_expr_text.substr(0, 14) + "…";
-  else
-    details = m_expr_text;
 
-  Progress progress("Running expression", details, {}, debugger);
+  Progress progress("Running expression",
+                    m_options.IsForUtilityExpr() ? "LLDB utility" : m_expr_text,
+                    {}, debugger);
 
   lldb::ExpressionResults expr_result = DoExecute(
       diagnostic_manager, exe_ctx, options, shared_ptr_to_me, result_var);

``````````

</details>


https://github.com/llvm/llvm-project/pull/174609