[Lldb-commits] [lldb] [lldb] Step over non-lldb breakpoints (PR #174348)

[David Spickett via lldb-commits]

================
@@ -138,6 +138,17 @@ class Architecture : public PluginInterface {
       std::shared_ptr<const UnwindPlan> current_unwindplan) {
     return lldb::UnwindPlanSP();
   }
+
+  /// Returns whether a given byte sequence is a valid breakpoint for the
+  /// architecture. Some architectures have breakpoint instructions that
+  /// have immediates that can take on any value, resulting in a family
+  /// of valid byte sequences. Bases the size comparison on the reference.
+  virtual bool IsValidBreakpointInstruction(llvm::ArrayRef<uint8_t> reference,
+                                            llvm::ArrayRef<uint8_t> observed) const {
+    if (reference.size() > observed.size())
----------------
DavidSpickett wrote:

And now I see that this method is customised for some architecures  - so some of the above may not apply but please check anyway.

https://github.com/llvm/llvm-project/pull/174348