[Lldb-commits] [lldb] [lldb][Format] Unwrap references to C-strings when printing C-string summaries (PR #174398)

[David Spickett via lldb-commits]

================
@@ -720,7 +720,7 @@ void FormatManager::LoadSystemFormatters() {
   TypeSummaryImpl::Flags string_flags;
   string_flags.SetCascades(true)
       .SetSkipPointers(true)
-      .SetSkipReferences(false)
+      .SetSkipReferences(true)
----------------
DavidSpickett wrote:

Closest I found to documentation for this is:
```
       -r ( --skip-references )
            Don't use this format for references-to-type objects.
```
So I think string_format was being used for references, but now is not.

I guess that this formatter didn't know how to remove the reference layer itself, and that's why it wasn't producing a summary. Now you've said not to use this for references, some generic reference to type handler kicks in and does a better job?

https://github.com/llvm/llvm-project/pull/174398