[Lldb-commits] [lldb] [lldb] support breakpoint by name on abi_tagged functions (PR #170527)

[Michael Buch via lldb-commits]

================
@@ -538,15 +539,156 @@ void CPlusPlusLanguage::CxxMethodName::Parse() {
   }
 }
 
-llvm::StringRef
-CPlusPlusLanguage::CxxMethodName::GetBasenameNoTemplateParameters() {
-  llvm::StringRef basename = GetBasename();
-  size_t arg_start, arg_end;
-  llvm::StringRef parens("<>", 2);
-  if (ReverseFindMatchingChars(basename, parens, arg_start, arg_end))
-    return basename.substr(0, arg_start);
+bool CPlusPlusLanguage::CxxMethodName::NameMatches(llvm::StringRef full_name,
+                                                   llvm::StringRef pattern,
+                                                   MatchOptions options) {
+  constexpr llvm::StringRef abi_prefix = "[abi:";
----------------
Michael137 wrote:

Sorry for the delay on this. We discussed offline that the intention of this PR is to be a targeted fix. Changing the name parser to drop the ABI tags might affect other places that use the parser and this seems specific enough of an issue where it would make sense to extend the parser further. It currently just skips over parsing ABI tags (but still includes them in the base-name that it returns). We have to adjust it store the ABI tags separately (and probably teach it to parse it in a few more places than it does currently).

https://github.com/llvm/llvm-project/pull/170527