[Lldb-commits] [lldb] 78d291e - [lldb][windows] only use a ConPTY if needed (#172877)

[via lldb-commits]

Author: Charles Zablit
Date: 2025-12-18T18:09:20Z
New Revision: 78d291eda012e069d85d15213c3d64afa19e9380

URL: https://github.com/llvm/llvm-project/commit/78d291eda012e069d85d15213c3d64afa19e9380
DIFF: https://github.com/llvm/llvm-project/commit/78d291eda012e069d85d15213c3d64afa19e9380.diff

LOG: [lldb][windows] only use a ConPTY if needed (#172877)

This patch fixes a regression caused by
https://github.com/llvm/llvm-project/pull/168729.

The changes ensure that we only create the process with a ConPTY if we
need to.

Added: 
    

Modified: 
    lldb/source/Host/windows/ProcessLauncherWindows.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/windows/ProcessLauncherWindows.cpp b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
index ae79171337726..4cfe6f3394be9 100644
--- a/lldb/source/Host/windows/ProcessLauncherWindows.cpp
+++ b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
@@ -93,8 +93,9 @@ ProcessLauncherWindows::LaunchProcess(const ProcessLaunchInfo &launch_info,
   startupinfoex.StartupInfo.dwFlags |= STARTF_USESTDHANDLES;
 
   HPCON hPC = launch_info.GetPTY().GetPseudoTerminalHandle();
-  bool use_pty =
-      hPC != INVALID_HANDLE_VALUE && launch_info.GetNumFileActions() == 0;
+  bool use_pty = hPC != INVALID_HANDLE_VALUE &&
+                 launch_info.GetNumFileActions() == 0 &&
+                 launch_info.GetFlags().Test(lldb::eLaunchFlagLaunchInTTY);
 
   HANDLE stdin_handle = GetStdioHandle(launch_info, STDIN_FILENO);
   HANDLE stdout_handle = GetStdioHandle(launch_info, STDOUT_FILENO);