[Lldb-commits] [lldb] [lldb][windows] refactor the version check in @skipIfWindows (PR #172838)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 18 03:55:01 PST 2025


================
@@ -322,8 +342,34 @@ def getDwarfVersion():
     return "0"
 
 
+def isExpectedVersion(
+    actual_version: str, required_version: str, operator: str
+) -> bool:
+    """Returns True if actual_version matches the required_version given the operator.
+    Any operator other than the following defaults to an equality test:
----------------
DavidSpickett wrote:

This default seems dangerous but it has always been this way. Maybe it's because raising an exception here gets eaten by the test framework.

https://github.com/llvm/llvm-project/pull/172838


More information about the lldb-commits mailing list