[Lldb-commits] [lldb] [lldb] Prefer exact symbol match when looking up by address (PR #172055)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 33227 tests passed
* 503 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### lldb-shell
<details>
<summary>lldb-shell.Commands/command-disassemble.s</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llvm-mc -filetype=obj -triple x86_64-pc-linux /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-disassemble.s.tmp
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llvm-mc -filetype=obj -triple x86_64-pc-linux /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-disassemble.s.tmp
# note: command had no output on stdout or stderr
# RUN: at line 4
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-disassemble.s.tmp -o "settings set interpreter.stop-command-source-on-error false"    -o "settings set stop-disassembly-max-size 8000"    -s /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit -o exit 2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-disassemble.s.tmp -o 'settings set interpreter.stop-command-source-on-error false' -o 'settings set stop-disassembly-max-size 8000' -s /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit -o exit
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s:17:15: error: CHECK-NEXT: is not on the line after the previous match
# | # CHECK-NEXT: command-disassemble.s.tmp`foo:
# |               ^
# | <stdin>:39:1: note: 'next' match was here
# | command-disassemble.s.tmp`foo:
# | ^
# | <stdin>:18:39: note: previous match ended here
# | (lldb) disassemble --start-address 0x0
# |                                       ^
# | <stdin>:19:1: note: non-matching line after previous match is here
# | command-disassemble.s.tmp`:
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-disassemble.s
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |          .
# |          .
# |          .
# |         34: command-disassemble.s.tmp[0x18] <+10>: int $0x1c 
# |         35: command-disassemble.s.tmp[0x1a] <+12>: int $0x1d 
# |         36: command-disassemble.s.tmp[0x1c] <+14>: int $0x1e 
# |         37: command-disassemble.s.tmp[0x1e] <+16>: int $0x1f 
# |         38: (lldb) disassemble --start-address 0x4 --end-address 0x8 
# |         39: command-disassemble.s.tmp`foo: 
# | next:17     !~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  error: match on wrong line
# |         40: command-disassemble.s.tmp[0x4] <+4>: int $0x12 
# |         41: command-disassemble.s.tmp[0x6] <+6>: int $0x13 
# |         42: (lldb) disassemble --start-address 0x8 --end-address 0x4 
# |         43: error: End address before start address. 
# |         44: (lldb) disassemble --address 0x0 
# |          .
# |          .
# |          .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/172055