[Lldb-commits] [lldb] [lldb] Add ReadCStrings API to Process (PR #172026)

[David Spickett via lldb-commits]

================
@@ -2135,6 +2135,63 @@ lldb::addr_t Process::FindInMemory(const uint8_t *buf, uint64_t size,
   return matches[0].GetBaseAddress().GetLoadAddress(&target);
 }
 
+llvm::SmallVector<std::optional<std::string>>
+Process::ReadCStringsFromMemory(llvm::ArrayRef<lldb::addr_t> addresses) {
+  // Make the same read width choice as ReadCStringFromMemory.
+  constexpr auto read_width = 256;
----------------
DavidSpickett wrote:

Could make this a global static constexpr SHOUTY_CONSTANT, whatever our style guide says. Then both can reference it.

https://github.com/llvm/llvm-project/pull/172026