[Lldb-commits] [lldb] The C++ dynamic typing tests are failing on Windows, skip for now. (PR #171922)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: None (jimingham)

<details>
<summary>Changes</summary>

This is a follow-on to:

https://github.com/llvm/llvm-project/pull/168611

which added a bunch of tests for detecting dynamic types of C++ result variables.  I don't actually know how well dynamic type detection works on Windows if at all.  It would require Windows support, since the Linux/Darwin version is specific to the Itanium ABI.

---
Full diff: https://github.com/llvm/llvm-project/pull/171922.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py (+2) 


``````````diff
diff --git a/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py b/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
index d560ce9059d15..cd6f1252de7f5 100644
--- a/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
+++ b/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
@@ -95,9 +95,11 @@ def check_dereference(self, result_varname, frame, expr_options):
         )
         self.assertEqual(method_result.signed, 500, "Got the right result value")
 
+    @skipIfWindows # Dynamic type resolution on Windows doesn't work
     def test_virtual_dynamic_results(self):
         self.do_test_dynamic_results(True)
 
+    @skipIfWindows # Dynamic type resolution on Windows doesn't work
     def test_non_virtual_dynamic_results(self):
         self.do_test_dynamic_results(False)
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/171922