[Lldb-commits] [lldb] [lldb-dap] Adjusting the initialize/launch flow to better match the spec. (PR #171549)

[John Harrison via lldb-commits]

================
@@ -21,16 +21,18 @@ using namespace lldb_dap::protocol;
 namespace lldb_dap {
 
 /// Launch request; value of command field is 'launch'.
-Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const {
+void LaunchRequestHandler::Run(
+    const LaunchRequestArguments &arguments,
+    llvm::unique_function<void(llvm::Error)> callback) const {
   // Initialize DAP debugger.
   if (Error err = dap.InitializeDebugger())
----------------
ashgti wrote:

With https://github.com/llvm/llvm-project/commit/5ab3375b2cf461ab02704d129a1f4d5ba1a1e275 this was moved into attach/launch because there is a possibility of a debugger being shared between sessions but with different targets. Although I'm not sure if that is fully operational yet...

https://github.com/llvm/llvm-project/pull/171549