[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

[Michael Buch via lldb-commits]

================
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) {
   return ValueObject::CreateValueObjectFromBool(m_target, value, "result");
 }
 
+llvm::Expected<CastKind>
+Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type,
+                            CompilerType target_type, int location) {
----------------
Michael137 wrote:

Why pass the `op_type` separately? Can't we just derive it from `operand` in this function?

Also can we rename `op_type` to `source_type`? I find that's an easier counter-part to `target_type` when reading the code

https://github.com/llvm/llvm-project/pull/170332