[Lldb-commits] [clang] [lldb] Reland [MS][clang] Add support for vector deleting destructors (PR #170337)

[Hans Wennborg via lldb-commits]

================
@@ -11193,6 +11193,7 @@ bool Sema::CheckDestructor(CXXDestructorDecl *Destructor) {
             FindDeallocationFunctionForDestructor(Loc, RD, /*Diagnose*/ false,
                                                   /*LookForGlobal*/ true, Name);
         Destructor->setOperatorGlobalDelete(GlobalOperatorDelete);
+        MarkFunctionReferenced(Loc, GlobalOperatorDelete);
----------------
zmodem wrote:

The comment above talks about "the lack of a global operator delete is not an error if there are no delete calls that require it".

Does that mean GlobalOperatorDelete could be null here, which would presumably be a problem for MarkFunctionReferenced, or how does that work?

And is it the same situation below?

https://github.com/llvm/llvm-project/pull/170337