[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

[Michael Buch via lldb-commits]

================
@@ -71,6 +71,11 @@ class Interpreter : Visitor {
                   std::shared_ptr<ExecutionContextScope> ctx,
                   const IntegerLiteralNode *literal);
 
+  llvm::Expected<CompilerType>
----------------
Michael137 wrote:

Can we encapsulate all these output parameters into a helper structure like `CastInfo`. Then return `llvm::Expected<CastInfo>`.

Looking at the call-site:
```
VerifyCastType(operand, op_type, node->GetType(),
                                    promo_kind, cast_kind, node->GetLocation());
```

As a new reader of this I'd be surprised to find that `node`'s type and location got modified by this call.

https://github.com/llvm/llvm-project/pull/170332