[Lldb-commits] [clang] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [openmp] [libc++] Implement P2242R1: `std::views::chunk` (PR #171109)

[via lldb-commits]

Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,jimingham
 <jingham at apple.com>,Matt Arsenault <Matthew.Arsenault at amd.com>,Priyanshu
 Kumar <10b.priyanshu at gmail.com>,Aiden Grossman <aidengrossman at google.com>,Maksim
 Levental <maksim.levental at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/171109 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions ,inc,cpp,h -- libcxx/include/__ranges/chunk_view.h libcxx/test/std/ranges/range.adaptors/range.chunk/adaptor.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/base.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/begin.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/ctad.compile.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/end.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/general.pass.cpp libcxx/test/std/ranges/range.adaptors/range.chunk/types.h libcxx/include/ranges libcxx/modules/std/ranges.inc --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libcxx/include/__ranges/chunk_view.h b/libcxx/include/__ranges/chunk_view.h
index b1c96223a..ae37c9784 100644
--- a/libcxx/include/__ranges/chunk_view.h
+++ b/libcxx/include/__ranges/chunk_view.h
@@ -113,7 +113,8 @@ class chunk_view<_View>::__outer_iterator {
 
   chunk_view* __parent_;
 
-  _LIBCPP_HIDE_FROM_ABI constexpr explicit __outer_iterator(chunk_view& __parent) : __parent_(std::addressof(__parent)) {}
+  _LIBCPP_HIDE_FROM_ABI constexpr explicit __outer_iterator(chunk_view& __parent)
+      : __parent_(std::addressof(__parent)) {}
 
 public:
   class value_type;
@@ -325,7 +326,7 @@ class chunk_view<_View>::__iterator {
   friend chunk_view;
 
   using _Parent _LIBCPP_NODEBUG = __maybe_const<_Const, chunk_view>;
-  using _Base   _LIBCPP_NODEBUG = __maybe_const<_Const, _View>;
+  using _Base _LIBCPP_NODEBUG   = __maybe_const<_Const, _View>;
 
   iterator_t<_Base> __current_         = iterator_t<_Base>();
   sentinel_t<_Base> __end_             = sentinel_t<_Base>();

``````````

</details>


https://github.com/llvm/llvm-project/pull/171109