[Lldb-commits] [lldb] [lldb] Add support for PC-less scripted frames (PR #170805)

[via lldb-commits]

================
@@ -57,10 +57,20 @@ let Definition = "debugger" in {
     Global,
     DefaultStringValue<"{${function.initial-function}{${module.file.basename}`}{${function.name-without-args}}:\\\\n}{${function.changed}\\\\n{${module.file.basename}`}{${function.name-without-args}}:\\\\n}{${ansi.fg.yellow}${current-pc-arrow}${ansi.normal} }${addr-file-or-load}{ <${function.concrete-only-addr-offset-no-padding}>}: ">,
     Desc<"The default disassembly format string to use when disassembling instruction sequences.">;
-  def FrameFormat: Property<"frame-format", "FormatEntity">,
-    Global,
-    DefaultStringValue<"frame #${frame.index}: ${ansi.fg.cyan}${frame.pc}${ansi.normal}{ ${module.file.basename}{`${function.name-with-args}{${frame.no-debug}${function.pc-offset}}}}{ at ${ansi.fg.cyan}${line.file.basename}${ansi.normal}:${ansi.fg.yellow}${line.number}${ansi.normal}{:${ansi.fg.yellow}${line.column}${ansi.normal}}}${frame.kind}{${function.is-optimized} [opt]}{${function.is-inlined} [inlined]}{${frame.is-artificial} [artificial]}\\\\n">,
-    Desc<"The default frame format string to use when displaying stack frame information for threads.">;
+  def FrameFormat
+      : Property<"frame-format", "FormatEntity">,
+        Global,
+        DefaultStringValue<
+            "frame #${frame.index}: ${ansi.fg.cyan}${frame.pc}${ansi.normal}{ "
+            "${module.file.basename}{`}}{${function.name-with-args}{${frame.no-"
+            "debug}${function.pc-offset}}}{ at "
+            "${ansi.fg.cyan}${line.file.basename}${ansi.normal}:${ansi.fg."
+            "yellow}${line.number}${ansi.normal}{:${ansi.fg.yellow}${line."
+            "column}${ansi.normal}}}${frame.kind}{${function.is-optimized} "
+            "[opt]}{${function.is-inlined} [inlined]}{${frame.is-artificial} "
+            "[artificial]}\\\\n">,
+        Desc<"The default frame format string to use when displaying stack "
+             "frame information for threads.">;
----------------
jimingham wrote:

Seems to me we shouldn't try to clang-format these strings, forcing the 80 character wrap makes them lots harder to read.  IIRC there's a #define that turns off clang-formatting for a section of code.  Might be good to use that here.

https://github.com/llvm/llvm-project/pull/170805