[Lldb-commits] [lldb] [lldb] Add support for PC-less scripted frames (PR #170762)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/include/lldb/Target/StackID.h lldb/source/Core/FormatEntity.cpp lldb/source/Plugins/Process/scripted/ScriptedFrame.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/StackFrameList.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Target/StackFrameList.cpp b/lldb/source/Target/StackFrameList.cpp
index 50f8c47c8..896a760f6 100644
--- a/lldb/source/Target/StackFrameList.cpp
+++ b/lldb/source/Target/StackFrameList.cpp
@@ -64,7 +64,7 @@ SyntheticStackFrameList::SyntheticStackFrameList(
 
 bool SyntheticStackFrameList::FetchFramesUpTo(
     uint32_t end_idx, InterruptionControl allow_interrupt) {
-  
+
   size_t num_synthetic_frames = 0;
   // Check if the thread has a synthetic frame provider.
   if (auto provider_sp = m_thread.GetFrameProvider()) {
@@ -84,7 +84,8 @@ bool SyntheticStackFrameList::FetchFramesUpTo(
       }
       StackFrameSP frame_sp = *frame_or_err;
       if (frame_sp->IsSynthetic())
-        frame_sp->GetStackID().SetCFA(num_synthetic_frames++, GetThread().GetProcess().get());
+        frame_sp->GetStackID().SetCFA(num_synthetic_frames++,
+                                      GetThread().GetProcess().get());
       // Set the frame list weak pointer so ExecutionContextRef can resolve
       // the frame without calling Thread::GetStackFrameList().
       frame_sp->m_frame_list_wp = shared_from_this();

``````````

</details>


https://github.com/llvm/llvm-project/pull/170762