[Lldb-commits] [lldb] [lldb-dap] Fix format string on Mac OS (PR #169933)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 4 22:08:49 PST 2025


================
@@ -87,8 +87,8 @@ Error AttachRequestHandler::Run(const AttachRequestArguments &args) const {
     // Use the unique target ID to get the target.
     target = dap.debugger.FindTargetByGloballyUniqueID(*target_id);
     if (!target.IsValid()) {
-      error.SetErrorStringWithFormat("invalid target_id %lu in attach config",
-                                     *target_id);
+      error.SetErrorStringWithFormat("invalid target_id %llu in attach config",
+                                     (unsigned long long)*target_id);
----------------
Michael137 wrote:

Personal preference would've been `invalid target_id %" PRIu64 " in attach config`, just because the `formatv` to `const char*` thing is a bit awkward. Would be nice if we had `SetErrorString` for LLVM format strings :)

https://github.com/llvm/llvm-project/pull/169933


More information about the lldb-commits mailing list