[Lldb-commits] [lldb] [lldb] support breakpoint by name on abi_tagged functions (PR #170527)

[Michael Buch via lldb-commits]

================
@@ -538,15 +539,156 @@ void CPlusPlusLanguage::CxxMethodName::Parse() {
   }
 }
 
-llvm::StringRef
-CPlusPlusLanguage::CxxMethodName::GetBasenameNoTemplateParameters() {
-  llvm::StringRef basename = GetBasename();
-  size_t arg_start, arg_end;
-  llvm::StringRef parens("<>", 2);
-  if (ReverseFindMatchingChars(basename, parens, arg_start, arg_end))
-    return basename.substr(0, arg_start);
+bool CPlusPlusLanguage::CxxMethodName::NameMatches(llvm::StringRef full_name,
+                                                   llvm::StringRef pattern,
+                                                   MatchOptions options) {
+  constexpr llvm::StringRef abi_prefix = "[abi:";
----------------
Michael137 wrote:

Remind me why we didnt modify the CPlusPlusNameParser? Not saying we should, but it does parse/skip ABI tags to some extent already

Alternatively, could we just search and replace all ABI tags in the name with a simple regex? (ignoring the question of whether we want to support setting breakpoint by specific tags, which i have some doubts about)

https://github.com/llvm/llvm-project/pull/170527