[Lldb-commits] [lldb] [lldb/Symbol] Relax LineEntry validity for PC-less frames (PR #158811)

[Greg Clayton via lldb-commits]

================
@@ -50,7 +50,7 @@ SBAddress SBLineEntry::GetStartAddress() const {
   LLDB_INSTRUMENT_VA(this);
 
   SBAddress sb_address;
-  if (m_opaque_up)
+  if (m_opaque_up && m_opaque_up->range.IsValid())
     sb_address.SetAddress(m_opaque_up->range.GetBaseAddress());
 
   return sb_address;
----------------
clayborg wrote:

Not really sure what this is doing, as the `sb_address` will end up in the exact same state as before this change. We will call `sb_address.SetAddress()` with an invalid address from `m_opaque_up->range.GetBaseAddress()`, and before it would just not call this function, but the resulting `sb_address` will be the same. I am I missing something?

https://github.com/llvm/llvm-project/pull/158811