[Lldb-commits] [lldb] [lldb][windows] bump the Windows API minimum version (PR #170284)

[Charles Zablit via lldb-commits]

charles-zablit wrote:

> > Please see the following RFC: [discourse.llvm.org/t/rfc-drop-support-running-llvm-on-windows-vista-7-8/80619/23](https://discourse.llvm.org/t/rfc-drop-support-running-llvm-on-windows-vista-7-8/80619/23)
> 
> This RFC was explicitly rejected; I think a new RFC should be posted to determine whether this is acceptable to the community or not.

I have just created a new RFC to discuss this: https://discourse.llvm.org/t/rfc-drop-support-for-lldb-on-windows-vista-7-8-and-early-versions-of-10/89037

> @charles-zablit Is it possible otherwise to gate https://github.com/llvm/llvm-project/pull/168729 under a runtime feature flag? Such as checking the OS version at runtime and dynamically retrieving the virtual console APIs. We’re already doing that in some places in llvm/lib/Support/.

I have not tried it, but I think It is possible yes. However, `lldb-dap` will greatly benefit from this new ConPTY API and I think saying we _support_ it on Windows Vista/7/8 with a limited/broken subset of features is confusing.

https://github.com/llvm/llvm-project/pull/170284