[Lldb-commits] [lldb] [LLDB] Fix deadlock in module callback when running in parallel (PR #168425)

[via lldb-commits]

================
@@ -216,6 +216,10 @@ class TargetList : public Broadcaster {
       llvm::StringRef triple_str, LoadDependentFiles load_dependent_files,
       const OptionGroupPlatform *platform_options, lldb::TargetSP &target_sp);
 
+  // Create Target Internal does not modify any state directly.
+  // Instead calling into methods which themselves should be thread-safe.
+  // We need to do this so the locate module call back doesn't cause a re-entry
+  // dead lock when creating the target.
----------------
jimingham wrote:

This is true, but while it explains why you don't need to not hold the target list mutex over the call to GetTargetInternal, it doesn't actually say not to do that, which would be helpful.

https://github.com/llvm/llvm-project/pull/168425