bulbazord wrote: Also looks fine to me. I'd say we need a few more tests though. Ideally this is an NFC upstream but let's make sure it's adoptable for downstream forks in a reasonable manner. https://github.com/llvm/llvm-project/pull/168797