[Lldb-commits] [lldb] [LLDB][PDB] Relax check for resolving breakpoint (PR #169932)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

<details>
<summary>Changes</summary>

The test was flaky, because it assumed that the breakpoint was always resolved before `r` was executed (https://github.com/llvm/llvm-project/pull/169728#issuecomment-3589799783). This removes the check for this order. It still checks that the breakpoint is resolved before it is hit.

---
Full diff: https://github.com/llvm/llvm-project/pull/169932.diff


1 Files Affected:

- (modified) lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp (+1-1) 


``````````diff
diff --git a/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp b/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
index ef7690b1720a6..64fbc84a98f24 100644
--- a/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
+++ b/lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
@@ -25,7 +25,7 @@
 // CHECK-NEXT: Breakpoint 1: no locations (pending).
 // CHECK: (lldb) target symbols add
 // CHECK: 1 location added to breakpoint 1
-// CHECK: (lldb) r
+
 // CHECK: * thread #1, stop reason = breakpoint 1.1
 // CHECK: (lldb) target variable a
 // CHECK-NEXT: (A) a = (x = 47)

``````````

</details>


https://github.com/llvm/llvm-project/pull/169932