[Lldb-commits] [lldb] [lldb] [disassembler] chore: enhance VariableAnnotator to return structured data: introduce VariableAnnotator::AnnotateStructured method (PR #169408)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Disassembler.cpp.o</summary>

```
FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Disassembler.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source/Core -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/usr/include/python3.12 -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/../clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/source -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-vla-extension -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Disassembler.cpp.o -MF tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Disassembler.cpp.o.d -o tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Disassembler.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:290:8: error: unknown type name 'contexpr'; did you mean 'constexpr'?
290 | static contexpr const llvm::StringLiteral kUndefLocationFormatted = "<undef>";
|        ^~~~~~~~
|        constexpr
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:312:57: error: use of undeclared identifier 'UndefLocation'; did you mean 'kUndefLocation'?
312 |     auto location = (annotation.location_description == UndefLocation
|                                                         ^~~~~~~~~~~~~
|                                                         kUndefLocation
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:289:44: note: 'kUndefLocation' declared here
289 | static constexpr const llvm::StringLiteral kUndefLocation = "undef";
|                                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:313:28: error: use of undeclared identifier 'UndefLocationFormatted'; did you mean 'kUndefLocationFormatted'?
313 |                          ? UndefLocationFormatted
|                            ^~~~~~~~~~~~~~~~~~~~~~
|                            kUndefLocationFormatted
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:290:43: note: 'kUndefLocationFormatted' declared here
290 | static contexpr const llvm::StringLiteral kUndefLocationFormatted = "<undef>";
|                                           ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:313:26: error: incompatible operand types ('const llvm::StringLiteral' and 'const std::string' (aka 'const basic_string<char>'))
313 |                          ? UndefLocationFormatted
|                          ^ ~~~~~~~~~~~~~~~~~~~~~~
314 |                          : annotation.location_description);
|                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:336:48: error: use of undeclared identifier 'UndefLocation'; did you mean 'kUndefLocation'?
336 |       annotation_entity.location_description = UndefLocation;
|                                                ^~~~~~~~~~~~~
|                                                kUndefLocation
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:289:44: note: 'kUndefLocation' declared here
289 | static constexpr const llvm::StringLiteral kUndefLocation = "undef";
|                                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:353:48: error: use of undeclared identifier 'UndefLocation'; did you mean 'kUndefLocation'?
353 |       annotation_entity.location_description = UndefLocation;
|                                                ^~~~~~~~~~~~~
|                                                kUndefLocation
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:289:44: note: 'kUndefLocation' declared here
289 | static constexpr const llvm::StringLiteral kUndefLocation = "undef";
|                                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:458:48: error: use of undeclared identifier 'UndefLocation'; did you mean 'kUndefLocation'?
458 |       annotation_entity.location_description = UndefLocation;
|                                                ^~~~~~~~~~~~~
|                                                kUndefLocation
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/source/Core/Disassembler.cpp:289:44: note: 'kUndefLocation' declared here
289 | static constexpr const llvm::StringLiteral kUndefLocation = "undef";
|                                            ^
7 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/169408