[Lldb-commits] [lldb] c1f24a5 - [windows] improve python3.dll load check (#168864)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 24 09:40:49 PST 2025
Author: Charles Zablit
Date: 2025-11-24T18:40:45+01:00
New Revision: c1f24a5205364686213a23182dc45df9c2383360
URL: https://github.com/llvm/llvm-project/commit/c1f24a5205364686213a23182dc45df9c2383360
DIFF: https://github.com/llvm/llvm-project/commit/c1f24a5205364686213a23182dc45df9c2383360.diff
LOG: [windows] improve python3.dll load check (#168864)
Added:
Modified:
lldb/tools/driver/Driver.cpp
Removed:
################################################################################
diff --git a/lldb/tools/driver/Driver.cpp b/lldb/tools/driver/Driver.cpp
index 0b77e0a4929a7..48107717abd31 100644
--- a/lldb/tools/driver/Driver.cpp
+++ b/lldb/tools/driver/Driver.cpp
@@ -477,18 +477,17 @@ bool AddPythonDLLToSearchPath() {
#endif
#ifdef LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME
-/// Returns whether `python3x.dll` is in the DLL search path.
+/// Returns true if `python3x.dll` can be loaded.
bool IsPythonDLLInPath() {
#define WIDEN2(x) L##x
#define WIDEN(x) WIDEN2(x)
- WCHAR foundPath[MAX_PATH];
- DWORD result =
- SearchPathW(nullptr, WIDEN(LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME), nullptr,
- MAX_PATH, foundPath, nullptr);
+ HMODULE h = LoadLibraryW(WIDEN(LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME));
+ if (!h)
+ return false;
+ FreeLibrary(h);
+ return true;
#undef WIDEN2
#undef WIDEN
-
- return result > 0;
}
#endif
More information about the lldb-commits
mailing list