[Lldb-commits] [lldb] [lldb] [test-suite] fix typo in variable in darwin builder (PR #169254)

via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 23 15:52:29 PST 2025


https://github.com/n2h9 created https://github.com/llvm/llvm-project/pull/169254

While taking a look at the code of lldb test-suite packages, I have noticed that in `get_triple_str` in `darwin.py` env is added inside a `components` list, which is probably supposed to be `component` (defined on the line 61). 

>From 415b6c7bae660f9970ad80b8031d19e3157fdc34 Mon Sep 17 00:00:00 2001
From: Nikita B <n2h9z4 at gmail.com>
Date: Mon, 24 Nov 2025 00:49:04 +0100
Subject: [PATCH] [lldb] [test-suite] fix typo in variable in darwin builder

Signed-off-by: Nikita B <n2h9z4 at gmail.com>
---
 lldb/packages/Python/lldbsuite/test/builders/darwin.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/packages/Python/lldbsuite/test/builders/darwin.py b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
index a023bda3ad801..eebe0ef47fd85 100644
--- a/lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ b/lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -60,7 +60,7 @@ def get_triple_str(arch, vendor, os, version, env):
 
     component = [arch, vendor, os + version]
     if env:
-        components.append(env)
+        component.append(env)
     return "-".join(component)
 
 



More information about the lldb-commits mailing list