[Lldb-commits] [lldb] [NFC][lldb] Remove duplicated checks (PR #169093)

[Sergei Druzhkov via lldb-commits]

https://github.com/DrSergei created https://github.com/llvm/llvm-project/pull/169093

Removed duplicated checks reported by cppcheck

>From 2029ec3785d00bf16e030111929c85173db9b444 Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei <serzhdruzhok at gmail.com>
Date: Tue, 18 Nov 2025 22:36:06 +0300
Subject: [PATCH] [NFC][lldb] Remove duplicated checks

---
 lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp | 3 ---
 lldb/source/Plugins/Language/ObjC/NSSet.cpp          | 2 --
 2 files changed, 5 deletions(-)

diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
index f4a695e036999..86f0a5ad78a9a 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
@@ -199,9 +199,6 @@ lldb::ChildCacheState VectorIteratorSyntheticFrontEnd::Update() {
   if (!valobj_sp)
     return lldb::ChildCacheState::eRefetch;
 
-  if (!valobj_sp)
-    return lldb::ChildCacheState::eRefetch;
-
   ValueObjectSP item_ptr =
       formatters::GetChildMemberWithName(*valobj_sp, m_item_names);
   if (!item_ptr)
diff --git a/lldb/source/Plugins/Language/ObjC/NSSet.cpp b/lldb/source/Plugins/Language/ObjC/NSSet.cpp
index 7d814e656dc5f..150b233507128 100644
--- a/lldb/source/Plugins/Language/ObjC/NSSet.cpp
+++ b/lldb/source/Plugins/Language/ObjC/NSSet.cpp
@@ -417,8 +417,6 @@ lldb_private::formatters::NSSetISyntheticFrontEnd::Update() {
   m_data_64 = nullptr;
   m_ptr_size = 0;
   ValueObjectSP valobj_sp = m_backend.GetSP();
-  if (!valobj_sp)
-    return lldb::ChildCacheState::eRefetch;
   if (!valobj_sp)
     return lldb::ChildCacheState::eRefetch;
   m_exe_ctx_ref = valobj_sp->GetExecutionContextRef();