[Lldb-commits] [lldb] [lldb] Fix testErrorMessages test cases in commands/trace/ (PR #168996)

via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 20 20:06:03 PST 2025


https://github.com/zyn-li created https://github.com/llvm/llvm-project/pull/168996

This patch fix the assertion text in `testErrorMessages` in some IntelPT test cases. 

Test: 
Enable intel-pt test plygin with cmake flag: `-DLLDB_BUILD_INTEL_PT=ON` and together with `DLIBIPT_INCLUDE_PATH` `DLIBIPT_LIBRARY_PATH` and `DLIBIPT_LIBRARY` 

build lldb 
 
lldb-dotest -p TestTraceDumpInfo
lldb-dotest -p TestTraceExport 
lldb-dotest -p TestTraceSave

>From 10a7ce0a2533d5d0a1e9e98f929f0ed666a22cf1 Mon Sep 17 00:00:00 2001
From: Zhiyuan Li <zynli at meta.com>
Date: Thu, 20 Nov 2025 16:05:01 -0800
Subject: [PATCH] Fixing the assertion string in commands/trace/ test cases

---
 lldb/test/API/commands/trace/TestTraceDumpInfo.py | 2 +-
 lldb/test/API/commands/trace/TestTraceExport.py   | 2 +-
 lldb/test/API/commands/trace/TestTraceSave.py     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lldb/test/API/commands/trace/TestTraceDumpInfo.py b/lldb/test/API/commands/trace/TestTraceDumpInfo.py
index 52449631f6aa9..d63884067a2cf 100644
--- a/lldb/test/API/commands/trace/TestTraceDumpInfo.py
+++ b/lldb/test/API/commands/trace/TestTraceDumpInfo.py
@@ -34,7 +34,7 @@ def testErrorMessages(self):
 
         self.expect(
             "thread trace dump info",
-            substrs=["error: Process is not being traced"],
+            substrs=["error: process is not being traced"],
             error=True,
         )
 
diff --git a/lldb/test/API/commands/trace/TestTraceExport.py b/lldb/test/API/commands/trace/TestTraceExport.py
index a6ca736d3c5a4..1aff7674ac6f6 100644
--- a/lldb/test/API/commands/trace/TestTraceExport.py
+++ b/lldb/test/API/commands/trace/TestTraceExport.py
@@ -38,7 +38,7 @@ def testErrorMessages(self):
 
         self.expect(
             f"thread trace export ctf --file {ctf_test_file}",
-            substrs=["error: Process is not being traced"],
+            substrs=["error: process is not being traced"],
             error=True,
         )
 
diff --git a/lldb/test/API/commands/trace/TestTraceSave.py b/lldb/test/API/commands/trace/TestTraceSave.py
index 4e3c70695bcee..776a0b199361c 100644
--- a/lldb/test/API/commands/trace/TestTraceSave.py
+++ b/lldb/test/API/commands/trace/TestTraceSave.py
@@ -40,7 +40,7 @@ def testErrorMessages(self):
         self.expect("run")
 
         self.expect(
-            "trace save", substrs=["error: Process is not being traced"], error=True
+            "trace save", substrs=["error: process is not being traced"], error=True
         )
 
     @skipIfNoIntelPT



More information about the lldb-commits mailing list