[Lldb-commits] [lldb] [lldb] add a marker before skipped frames (PR #167550)

[Jonas Devlieghere via lldb-commits]

================
@@ -879,11 +881,43 @@ StackFrameList::GetStackFrameSPForStackFramePtr(StackFrame *stack_frame_ptr) {
   return ret_sp;
 }
 
+bool StackFrameList::IsNextFrameHidden(lldb_private::StackFrame &frame) {
+  uint32_t frame_idx = frame.GetFrameIndex();
+  StackFrameSP frame_sp = GetFrameAtIndex(frame_idx + 1);
+  if (!frame_sp)
+    return false;
+  return frame_sp->IsHidden();
+}
+
+bool StackFrameList::IsPreviousFrameHidden(lldb_private::StackFrame &frame) {
+  uint32_t frame_idx = frame.GetFrameIndex();
+  if (frame_idx == 0)
+    return false;
+  StackFrameSP frame_sp = GetFrameAtIndex(frame_idx - 1);
+  if (!frame_sp)
+    return false;
+  return frame_sp->IsHidden();
+}
+
+std::wstring StackFrameList::FrameMarker(lldb::StackFrameSP frame_sp,
+                                         lldb::StackFrameSP selected_frame_sp) {
+  if (frame_sp == selected_frame_sp) {
+    return TerminalSupportsUnicode() ? L" * " : L"* ";
+  } else if (!TerminalSupportsUnicode()) {
+    return L"  ";
+  } else if (IsPreviousFrameHidden(*frame_sp)) {
+    return L" ﹉";
+  } else if (IsNextFrameHidden(*frame_sp)) {
+    return L" ﹍";
+  }
----------------
JDevlieghere wrote:

No braces

https://github.com/llvm/llvm-project/pull/167550