[Lldb-commits] [lldb] [lldb][windows] add color to the Python.dll not found error (PR #168718)

via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 19 06:57:04 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

Make the `Python.dll not found` error message stand out more by using the `llvm::WithColor::error()` method.

---

### Example

#### Before

<img width="782" height="431" alt="Screenshot 2025-11-19 at 15 50 22" src="https://github.com/user-attachments/assets/93960c50-cbf2-41f7-aba3-2f2a8af916cc" />

#### After

<img width="780" height="430" alt="Screenshot 2025-11-19 at 15 54 28" src="https://github.com/user-attachments/assets/f7f4954b-0ce3-4a4b-b9af-5af876032573" />

---
Full diff: https://github.com/llvm/llvm-project/pull/168718.diff


1 Files Affected:

- (modified) lldb/tools/driver/Driver.cpp (+3-3) 


``````````diff
diff --git a/lldb/tools/driver/Driver.cpp b/lldb/tools/driver/Driver.cpp
index bebf1a70d50e9..0b77e0a4929a7 100644
--- a/lldb/tools/driver/Driver.cpp
+++ b/lldb/tools/driver/Driver.cpp
@@ -508,12 +508,12 @@ void SetupPythonRuntimeLibrary() {
   if (AddPythonDLLToSearchPath() && IsPythonDLLInPath())
     return;
 #endif
-  llvm::errs() << "error: unable to find '"
-               << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
+  WithColor::error() << "unable to find '"
+                     << LLDB_PYTHON_RUNTIME_LIBRARY_FILENAME << "'.\n";
   return;
 #elif defined(LLDB_PYTHON_DLL_RELATIVE_PATH)
   if (!AddPythonDLLToSearchPath())
-    llvm::errs() << "error: unable to find the Python runtime library.\n";
+    WithColor::error() << "unable to find the Python runtime library.\n";
 #endif
 }
 #endif

``````````

</details>


https://github.com/llvm/llvm-project/pull/168718


More information about the lldb-commits mailing list