[Lldb-commits] [lldb] [llvm] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> I used what [is-unicode-supported](https://www.npmjs.com/package/is-unicode-supported) uses, which is a very (50M weekly downloads/week) popular NPM package:

Good enough for me :+1: 

> We use WriteConsoleW since https://github.com/llvm/llvm-project/pull/156469, so maybe the Windows code path should always return true instead of checking for the WT_SESSION env var?

If you feel confident enough in your testing, sure.

This PR is fine as is though. Worst case it's too cautious and it can be changed later. I suspect the majority of people will be using Windows Terminal by now and if they're not, their first instinct would probably be to see if it solves the issue.

https://github.com/llvm/llvm-project/pull/168603