[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #168603)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

I'd like a citation for the WT_SESSION variable.

And it is a bit worrying that one of the top results for that name is one of the Windows Terminal devs (I'm pretty sure it is) telling a project not to use it https://github.com/Textualize/rich/issues/140.

> There's a small handful of issues with detecting WT_SESSION and using that as an indicator that you can use advanced VT:

Though in our case, we're not looking for those features specifically so it's probably ok.

I also found https://github.com/microsoft/terminal/issues/13006. Not sure if that applies here, even if it does, I don't know of an alternative way to detect the terminal.

There is https://github.com/microsoft/terminal/issues/1040 but it's still open.

We can certainly say that if we find WT_SESSION, it's definitely Windows terminal. If we don't find it, maybe it is, but we'll be cautious and not emit Unicode anyway.

https://github.com/llvm/llvm-project/pull/168603