[Lldb-commits] [lldb] [lldb][test] Correctly skip a test on a 32-bit target (PR #168631)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Igor Kudrin (igorkudrin)

<details>
<summary>Changes</summary>

The test was added in #<!-- -->147252. On a 32-bit target, it fails with error:
```
  File "...\TestDataFormatterLibcxxInvalidString.py", line 23, in test
    self.skip()
    ^^^^^^^^^
AttributeError: 'LibcxxInvalidStringDataFormatterTestCase' object has no attribute 'skip'
```

---
Full diff: https://github.com/llvm/llvm-project/pull/168631.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py (+1-1) 


``````````diff
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
index ae8e0ac08c2b0..b504c01b06da4 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
@@ -20,7 +20,7 @@ def test(self):
         frame = thread.frames[0]
 
         if not self.process().GetAddressByteSize() == 8:
-            self.skip()
+            self.skipTest("The test requires a 64-bit process")
 
         # The test assumes that std::string is in its cap-size-data layout.
         self.expect(

``````````

</details>


https://github.com/llvm/llvm-project/pull/168631