[Lldb-commits] [lldb] [lldb] [disassembler] chore: enhance VariableAnnotator to return structured data (PR #165163)

[via lldb-commits]

n2h9 wrote:

> While updating the test I have noticed that we receive structured annotations by calling `annotations = inst.GetVariableAnnotations(target)`. Which is probably slightly redundant, because we receive instructions from target, and then variable annotations from particular instructions, but still need to pass target 🤔 .
> 
> The reason for this is that the original [annotate](https://github.com/llvm/llvm-project/blob/main/lldb/include/lldb/Core/Disassembler.h#L589) method expects a target and module.
> 
> I think we can simplify and keep only `instruction` as method param, and get `module` from address inside the method, I updated in this [commit](https://github.com/llvm/llvm-project/pull/165163/commits/651b407a5f955b21b9b514811570cb3f07df7b3e) let me know if it makes sense 😇 .
> 
> Thank you 🙇‍♀️ .

I moved this update to a separate pr to maybe make it easier to review and deliver faster :blush: https://github.com/llvm/llvm-project/pull/168276 

https://github.com/llvm/llvm-project/pull/165163