[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [clang] Refactor option-related code from clangDriver into new clangOptions library (PR #163659)

[Naveen Seth Hanig via lldb-commits]

================

----------------
naveen-seth wrote:

> @naveen-seth there's still a reference to `Options.h` in https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Driver.h#L22 that makes clang unbuildable.

Hmm this is odd. Looking at the git diff here, it should have been removed.
Also looking at the revision which landed in the main branch, I can't find any `#include/Driver/Options.h`.

https://github.com/llvm/llvm-project/blob/9a783b63e647d95e001f55464a9bc7fa0c3929c3/clang/include/clang/Driver/Driver.h#L19-L25

The pre-commit CI and my local builds (with `BUILD_SHARED_LIBS=ON`) also went through fine without hitting any related errors. Looking at the post commit CI, I also didn't find the corresponding error.

@npanchen can you point me to where you are seeing the failure?

https://github.com/llvm/llvm-project/pull/163659